Skip to content

Extend getrs with trans_code argument #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2025
Merged

Extend getrs with trans_code argument #2563

merged 7 commits into from
Sep 15, 2025

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggests expanding getrs function by adding trans_code argument and handling its values to match the behavior of oneapi::mkl::lapack::getrs

These changes are the first step to implement lu_solve(lu_and_piv, b, trans=0, overwrite_b=False, check_finite=True)

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_35 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Aug 18, 2025 •
edited
Loading

Coverage Status

coverage: 71.64% (+0.02%) from 71.624%
when pulling 201d361 on pass_trans_to_getrs
into 1acd558 on master.

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 1, 2025
antonwolfy
antonwolfy reviewed Sep 3, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlad-perevezentsev vlad-perevezentsev merged commit 07d455e into master Sep 15, 2025
89 of 94 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the pass_trans_to_getrs branch September 15, 2025 14:42
github-actions bot added a commit that referenced this pull request Sep 15, 2025
@github-actions
Extend getrs with trans_code argument (#2563)
0865586 
This PR suggests expanding `getrs` function by adding `trans`
argument and handling its values to match the behavior of
`oneapi::mkl::lapack::getrs` 07d455e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy